GPU Bot Details

This page describes in detail how the GPU bots are set up, which files affect their configuration, and how to both modify their behavior and add new bots.

Overview of the GPU bots' setup

Chromium's GPU bots, compared to the majority of the project's test machines, are physical pieces of hardware. When end users run the Chrome browser, they are almost surely running it on a physical piece of hardware with a real graphics processor. There are some portions of the code base which simply can not be exercised by running the browser in a virtual machine, or on a software implementation of the underlying graphics libraries. The GPU bots were developed and deployed in order to cover these code paths, and avoid regressions that are otherwise inevitable in a project the size of the Chromium browser.

The GPU bots are utilized on the chromium.gpu and chromium.gpu.fyi waterfalls, and various tryservers, as described in Using the GPU Bots.

The vast majority of the hardware for the bots lives in the Chrome-GPU Swarming pool. The waterfall bots are simply virtual machines which spawn Swarming tasks with the appropriate tags to get them to run on the desired GPU and operating system type. So, for example, the Win7 Release (NVIDIA) bot is actually a virtual machine which spawns all of its jobs with the Swarming parameters:

gpu: 10de:104a
OS: Windows-2008ServerR2-SP1
pool: Chrome-GPU

Since the GPUs in the Swarming pool are mostly homogeneous, this is sufficient to target the pool of Windows 7-like NVIDIA machines. (There are a few Windows 8-like NVIDIA bots in the pool, which necessitates the very-precise OS specifier.)

Details about the bots can be found on https://chromium-swarm.appspot.com/ and by using src/tools/swarming_client/swarming.py , for example "swarming.py bots". If you are authenticated with @google.com credentials you will be able to make queries of the bots and see, for example, which GPUs are available.

The waterfall bots run tests on a single GPU type in order to make it easier to see regressions or flakiness that affect only a certain type of GPU.

The tryservers like win_chromium_rel_ng which include GPU tests, on the other hand, run tests on more than one GPU type. As of this writing, the Windows tryservers ran tests on NVIDIA and AMD GPUs; the Mac tryservers ran tests on Intel and NVIDIA GPUs. The way these tryservers' tests are specified is simply by mirroring how one or more waterfall bots work. This is an inherent property of the chromium_trybot recipe, which was designed to eliminate differences in behavior between the tryservers and waterfall bots. Since the tryservers mirror waterfall bots, if the waterfall bot is working, the tryserver must almost inherently be working as well.

There are a few one-off GPU configurations on the waterfall where the tests are run locally on physical hardware, rather than via Swarming. A few examples are:
There are a couple of reasons to continue to support running tests on a specific machine: it might be too expensive to deploy the required multiple copies of said hardware, or the configuration might not be reliable enough to begin scaling it up.

Adding a new isolated test to the bots

Adding a new test step to the bots requires that the test run via an isolate. Isolates describe both the binary and data dependencies of an executable, and are the underpinning of how the Swarming system works. See the LUCI wiki for background on Isolates and Swarming.

Adding a new isolate

  1. Define your target using the "test" template in src/testing/test.gni. See test("gl_tests") in src/gpu/BUILD.gn for an example. For a more complex example which invokes a series of scripts which finally launches the browser, see src/chrome/telemetry_gpu_test.isolate.
  2. Add an entry to src/testing/buildbot/gn_isolate_map.pyl that refers to your target. Find a similar target to yours in order to determine the "type". The type is referenced in src/tools/mb/mb_config.pyl.
At this point you can build and upload your isolate to the isolate server.

See Isolated Testing for SWEs for the most up-to-date instructions. These instructions are a copy which show how to run an isolate that's been uploaded to the isolate server on your local machine rather than on Swarming.

 If cd'd into src/:
  1. ./tools/mb/mb.py isolate //out/Release [target name]
    1. For example:
      ./tools/mb/mb.py isolate //out/Release angle_end2end_tests
  2. python tools/swarming_client/isolate.py batcharchive -I https://isolateserver.appspot.com out/Release/[target name].isolated.gen.json
    1. For example:
      python tools/swarming_client/isolate.py batcharchive -I https://isolateserver.appspot.com out/Release/angle_end2end_tests.isolated.gen.json
  3. This will write a hash to stdout. You can run it via:
    python tools/swarming_client/run_isolated.py -I https://isolateserver.appspot.com -s [HASH] -- [any additional args for the isolate]
See the section below on isolate server credentials.

Adding your new isolate to the tests that are run on the bots

See Adding new steps to the GPU bots for details on this process.

Relevant files that control the operation of the GPU bots

In the tools/build workspace:
  • masters/master.chromium.gpu and masters/master.chromium.gpu.fyi:
    • builders.pyl in these two directories defines the bots that show up on the waterfall. If you are adding a new bot, you need to add it to builders.pyl and use go/bug-a-trooper to request a restart of either master.chromium.gpu or master.chromium.gpu.fyi.
    • Only changes under masters/ require a waterfall restart. All other changes – for example, to scripts/slave/ in this workspace, or the Chromium workspace – do not require a master restart (and go live the minute they are committed).
  • scripts/slave/recipe_modules/chromium_tests/:
    • chromium_gpu.py and chromium_gpu_fyi.py define the following for each builder and tester:
      • How the workspace is checked out (e.g., this is where top-of-tree ANGLE is specified)
      • The build configuration (e.g., this is where 32-bit vs. 64-bit is specified)
      • Various gclient defines (like compiling in the hardware-accelerated video codecs, and enabling compilation of certain tests, like the dEQP tests, that can't be built on all of the Chromium builders)
      • Note that the GN configuration of the bots is also controlled by mb_config.pyl in the Chromium workspace; see below.
    • trybots.py defines how try bots mirror one or more waterfall bots.
      • The concept of try bots mirroring waterfall bots ensures there are no differences in behavior between the waterfall bots and the try bots. This helps ensure that a CL will not pass the commit queue and then break on the waterfall.
      • This file defines the behavior of the following GPU-related try bots:
        • linux_chromium_rel_ng, mac_chromium_rel_ng, and win_chromium_rel_ng, which run against every Chromium CL, and which mirror the behavior of bots on the chromium.gpu waterfall.
        • The ANGLE try bots, which run against ANGLE CLs, and mirror the behavior of the chromium.gpu.fyi waterfall (including using top-of-tree ANGLE, and running additional tests not run by the regular Chromium try bots)
        • The optional GPU try servers linux_optional_gpu_tests_rel, mac_optional_gpu_tests_rel and win_optional_gpu_tests_rel, which are triggered manually and run some tests which can't be run on the regular Chromium try servers mainly due to lack of hardware capacity.
In the Chromium workspace:
In the infradata/config workspace (Google internal only, sorry):
  • configs/chromium-swarm/bots.cfg
    • Defines a "Chrome-GPU" Swarming pool which contains most of the specialized hardware: as of this writing, the Windows and Linux NVIDIA bots, the Windows AMD bots, and the MacBook Pros with NVIDIA and AMD GPUs. New GPU hardware should be added to this pool.

Walkthroughs of various maintenance scenarios

This section describes various common scenarios that might arise when maintaining the GPU bots, and how they'd be addressed.

How to add a new test or an entire new step to the bots

This is described in Adding new tests to the GPU bots.

How to add a new bot

The first decision point when adding a new GPU bot is whether it is a one-off piece of hardware, or one which is expected to be scaled up at some point. If it's a one-off piece of hardware, it can be added to the chromium.gpu.fyi waterfall as a non-swarmed test machine. If it's expected to be scaled up at some point, the hardware should be added to the swarming pool. These two scenarios are described in more detail below.

How to add a new, non-swarmed, physical bot to the chromium.gpu.fyi waterfall

  1. Work with the Chrome Infrastructure Labs team to get the hardware deployed so it can talk to the chromium.gpu.fyi master.
  2. Create a CL in the build workspace which:
    1. Add the new machine to masters/master.chromium.gpu.fyi/builders.pyl.
    2. Add the new machine to scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py. Set the 'enable_swarming' property to False.
    3. Retrain recipe expectations (scripts/slave/recipes.py --use-bootstrap test train) and add the newly created JSON file(s) corresponding to the new machines to your CL.
  3. Create a CL in the Chromium workspace to:
    1. Add the new machine to src/content/test/gpu/generate_buildbot_json.py. Make sure to set the 'swarming' property to False.
    2. If the machine runs GN, add a description to src/tools/mb/mb_config.pyl.
  4. Once the build workspace CL lands, use go/bug-a-trooper (or contact kbr@) to schedule a restart of the chromium.gpu.fyi waterfall. This is only necessary when modifying files under the masters/ directory. A reboot of the machine may be needed once the waterfall has been restarted in order to make it connect properly.
  5. The CLs from (2) and (3) can land in either order, though it is preferable to land the Chromium-side CL first so that the machine knows what tests to run the first time it boots up.

How to add a new swarmed bot to the chromium.gpu.fyi waterfall

When deploying a new GPU configuration, it should be added to the chromium.gpu.fyi waterfall first. The chromium.gpu waterfall should be reserved for those GPUs which are tested on the commit queue. (Some of the bots violate this rule – namely, the Debug bots – though we should strive to eliminate these differences.) Once the new configuration is ready to be fully deployed on tryservers, bots can be added to the chromium.gpu waterfall, and the tryservers changed to mirror them.

In order to add Release and Debug waterfall bots for a new configuration, experience has shown that at least 4 physical machines are needed in the swarming pool. The reason is that the tests all run in parallel on the Swarming cluster, so the load induced on the swarming bots is higher than it would be for a non-swarmed bot that executes its tests serially.

With these prerequisites, these are the steps to add a new swarmed bot. (Actually, pair of bots -- Release and Debug.)
  1. Work with the Chrome Infrastructure Labs team to get the (minimum 4) physical machines added to the Swarming pool. Use https://chromium-swarm.appspot.com/ or "src/tools/swarming_client/swarming.py bots" to determine the PCI IDs of the GPUs in the bots. (These instructions will need to be updated for Android bots which don't have PCI buses.)
    1. Make sure to add these new machines to the Chrome-GPU Swarming pool by creating a CL against configs/chromium-swarm/bots.cfg in the infradata/config workspace.
  2. File a Chrome Infrastructure Labs ticket requesting 2 virtual machines for the testers. These need to match the OS of the physical machines and builders because of limitations in the scripts which transfer builds from the builder to the tester; see this feature request. For example, if you're adding a "Windows 7 CoolNewGPUType" tester, you'll need 2 Windows VMs.
  3. Once the VMs are ready, create a CL in the build workspace which:
    1. Adds the new VMs as the Release and Debug bots in masters/master.chromium.gpu.fyi/builders.pyl.
    2. Adds the new VMs to scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py. Make sure to set the 'enable_swarming' property to True. Double-check the parent_buildername property for each. It must match the Release/Debug flavor of the builder.
    3. Retrain recipe expectations (scripts/slave/recipes.py --use-bootstrap test train) and add the newly created JSON file(s) corresponding to the new machines to your CL.
  4. Create a CL in the Chromium workspace which:
    1. Adds the new machine to src/content/test/gpu/generate_buildbot_json.py.
      1. The swarming dimensions are crucial. These must match the GPU and OS type of the physical hardware in the Swarming pool. This is what causes the VMs to spawn their tests on the correct hardware. Make sure to use the Chrome-GPU pool, and that the new machines were specifically added to that pool.
      2. Make sure to set the 'swarming' property to True for both the Release and Debug bots.
      3. Make triply sure that there are no collisions between the new hardware you're adding and hardware already in the Swarming pool. For example, it used to be the case that all of the Windows NVIDIA bots ran the same OS version. Later, the Windows 8 flavor bots were added. In order to avoid accidentally running tests on Windows 8 when Windows 7 was intended, the OS in the swarming dimensions of the Win7 bots had to be changed from 'win' to 'Windows-2008ServerR2-SP1' (the Win7-like flavor running in our data center). Similarly, the Win8 bots had to have a very precise OS description ('Windows-2012ServerR2-SP0').
    2. If the machine runs GN, adds a description to src/tools/mb/mb_config.pyl.
  5. Once the tools/build CL lands, use go/bug-a-trooper (or contact kbr@) to schedule a restart of the chromium.gpu.fyi waterfall. This is only necessary when modifying files under the masters/ directory. A reboot of the VMs may be needed once the waterfall has been restarted in order to make them connect properly.
  6. The CLs from (3) and (4) can land in either order, though it is preferable to land the Chromium-side CL first so that the machine knows what tests to run the first time it boots up.

How to start running tests on a new GPU type on an existing try bot

Let's say that you want to cause the win_chromium_rel_ng try bot to run tests on CoolNewGPUType in addition to the types it currently runs (as of this writing, NVIDIA and AMD). To do this:
  1. Make sure there is enough hardware capacity. Unfortunately, tools to report utilization of the Swarming pool are still being developed, but a back-of-the-envelope estimate is that you will need a minimum of 30 machines in the Swarming pool to run the current set of GPU tests on the tryservers. We estimate that 90 machines will be needed in order to additionally run the WebGL 2.0 conformance tests. Plan for the larger capacity, as it's desired to run the larger test suite on as many configurations as possible.
  2. Deploy Release and Debug testers on the chromium.gpu waterfall, following the instructions for the chromium.gpu.fyi waterfall above. You will also need to temporarily add suppressions to tests/masters_recipes_test.py for these new testers since they aren't yet covered by try bots and are going on a non-FYI waterfall. Make sure these run green for a day or two before proceeding.
  3. Create a CL in the tools/build workspace, adding the new Release tester to win_chromium_rel_ng's bot_ids list in scripts/slave/recipe_modules/chromium_tests/trybots.py. Rerun 'scripts/slave/recipes.py --use-bootstrap test train'.
  4. Once the CL in (3) lands, the commit queue will immediately start running tests on the CoolNewGPUType configuration. Be vigilant and make sure that tryjobs are green. If they are red for any reason, revert the CL and figure out offline what went wrong.

How to add a new optional try bot

The "optional" GPU try bots are a concession to the reality that there are some long-running GPU test suites that simply can not run against every Chromium CL. They run some additional tests that are usually run only on the chromium.gpu.fyi waterfall. Some of these tests, like the WebGL 2.0 conformance suite, are intended to be run on the normal try bots once hardware capacity is available. Some are not intended to ever run on the normal try bots.

The optional try bots are a little different because they mirror waterfall bots that don't actually exist. The waterfall bots' specifications exist only to tell the optional try bots which tests to run.

Let's say that you intended to add a new such optional try bot on Windows. Call it 'win_new_optional_tests_rel' for example. Now, if you wanted to just add this GPU type to the existing win_optional_gpu_tests_rel try bot, you'd just follow the instructions above ("How to start running tests on a new GPU type on an existing try bot"). The steps below describe how to spin up an entire new optional try bot.
  1. Make sure that you have some swarming capacity for the new GPU type. Since it's not running against all Chromium CLs you don't need the recommended 30 minimum bots, though ~10 would be good.
  2. Create a CL in the Chromium workspace:
    1. Add your new bot (for example, "Optional Win7 Release (CoolNewGPUType)") to the chromium.gpu.fyi waterfall in generate_buildbot_json.py. (Note, this is a bad example: the "optional" bots have special semantics in this script. You'd probably want to define some new category of bot if you didn't intend to add this to win_optional_gpu_tests_rel.) 
    2. Re-run the script to regenerate the JSON files.
  3. Land the above CL.
  4. Create a CL in the tools/build workspace:
    1. Modify masters/master.tryserver.chromium.win's master.cfg and slaves.cfg to add the new tryserver. Follow the pattern for the existing win_optional_gpu_tests_rel tryserver. Namely, add the new entry to master.cfg, and add the new tryserver to the 'optional_builders' list in slaves.cfg.
    2. Modify scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py to add the new "Optional Win7 Release (CoolNewGPUType)" entry.
    3. Modify scripts/slave/recipe_modules/chromium_tests/trybots.py to add the new win_new_optional_tests_rel try bot, mirroring "Optional Win7 Release (CoolNewGPUType)".
  5. Land the above CL and request an off-hours restart of the tryserver.chromium.win waterfall.
  6. Now you can send CLs to the new bot with:
    git cl try -m tryserver.chromium.win -b win_new_optional_tests_rel

How to test and deploy a driver update

Let's say that you want to roll out an update to the graphics drivers on one of the configurations like the Win7 NVIDIA bots. The responsible way to do this is to run the new driver on one of the waterfalls for a day or two to make sure the tests are running reliably green before rolling out the driver update everywhere. To do this:
  1. Work with the Chrome Infrastructure Labs team to deploy a single, non-swarmed, physical machine on the chromium.gpu.fyi waterfall running the new driver. The OS and GPU should exactly match the configuration you intend to upgrade. See the instructions above for "How to add a new, non-swarmed, physical bot to the chromium.gpu.fyi waterfall".
  2. Hopefully, the new machine will pass the pixel tests. If it doesn't, then unfortunately, it'll be necessary to follow the instructions on updating the pixel tests to temporarily suppress the failures on this particular configuration. Keep the time window for these test suppressions as narrow as possible.
  3. Watch the new machine for a day or two to make sure it's stable.
  4. When it is, ask the Chrome Infrastructure Labs team to roll out the driver update across all of the similarly configured bots in the swarming pool.
  5. If necessary, update pixel test expectations and remove the suppressions added above.
  6. Prepare and land a CL removing the temporary machine from the chromium.gpu.fyi waterfall. Request a waterfall restart.
  7. File a ticket with the Chrome Infrastructure Labs team to reclaim the temporary machine.
Note that with recent improvements to Swarming, in particular this RFE and others, these steps are no longer strictly necessary – it's possible to target Swarming jobs at a particular driver version. If generate_buildbot_json.py were improved to be more specific about the driver version on the various bots, then the machines with the new drivers could simply be added to the Swarming pool, and this process could be a lot simpler. Patches welcome. :)

Credentials for various servers

Working with the GPU bots requires credentials to various services: the isolate server, the swarming server, and cloud storage.

Isolate server credentials

To upload and download isolates you must first authenticate to the isolate server. From a Chromium checkout, run:

./src/tools/swarming_client/auth.py login --service=https://isolateserver.appspot.com

This will open a web browser to complete the authentication flow. A @google.com email address is required in order to properly authenticate.

To test your authentication, find a hash for a recent isolate. Consult the instructions on Running Binaries from the Bots Locally to find a random hash from a target like gl_tests. Then run the following:

If authentication succeeded, this will silently download a file called "delete_me" into the current working directory. If it failed, the script will report multiple authentication errors. In this case, use the following command to log out and then try again:

./src/tools/swarming_client/auth.py logout --service=https://isolateserver.appspot.com

Swarming server credentials

The swarming server uses the same auth.py script as the isolate server. You will need to authenticate if you want to manually download the results of previous swarming jobs, trigger your own jobs, or run "swarming.py reproduce" to re-run a remote job on your local workstation. Follow the instructions above, replacing the service with:

https://chromium-swarm.appspot.com

Cloud storage credentials

Authentication to Google Cloud Storage is needed for a couple of reasons: uploading pixel test results to the cloud, and potentially uploading and downloading builds as well, at least in Debug mode. Use the copy of gsutil in depot_tools/third_party/gsutil/gsutil, and follow the Google Cloud Storage instructions to authenticate. You must use your @google.com email address and be a member of the Chrome GPU team in order to receive read-write access to the appropriate cloud storage buckets. Roughly:
  1. Run gsutil config
  2. Copy/paste the URL into your browser
  3. Log in with your @google.com account
  4. Allow the app to access the information it requests
  5. Copy-paste the resulting key back into your Terminal
  6. Press "enter" when prompted for a project-id (i.e., leave it empty)
At this point you should be able to write to the cloud storage bucket.

Navigate to https://storage.cloud.google.com/?arg=chromium-gpu-archive to view the contents of the cloud storage bucket.
Comments